Allow multiple caplitalized words (like typical vendor names) in ACL resource IDs #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I've also been meaning to send a PR for this :) |
|
@Vinai Thanks Vinai! Big fan of yours, much of my Magento knowledge comes from your stack overflow answers. @vpelipenko Any reason this hasn't been merged yet? Do you need anything else from me? |
magento-team
pushed a commit
that referenced
this pull request
Aug 9, 2017
Related Pull Requests magento/magento2ee#658
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current xsd schema allows for a single capitalized word, followed by an underscore, followed by any mix of lowercase and uppercase letters. All of this is followed by
::and another, more specific string that can contain a mix of lowercase and uppercase letters. For example,However, it seems that common practice will be to use the module name Vendor_Module as that first section of the
idattribute. Since it is very common for vendor names to be two capitalized words, I've updated the schema to allow for something like below.To be clear, with the original xsd, the resource ID would have to be
Blueacorn_UrlTracker::urltracker, which would cause inconsistent naming across the application.